-
Notifications
You must be signed in to change notification settings - Fork 56
feat(ci): parse wasm-bindgen version to install correct client #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ci): parse wasm-bindgen version to install correct client #84
Conversation
|
I don't really see how this fixes the "issue" since the wasm-bindgen version used in the Cargo.lock is the version that needs to match, and this PR will thus just invert the problem, leading to an old version in CI and a new version in lock. The relevant CI for your failed CI run shows that you installed wasm-bindgen .106: https://github.com/ThierryBerger/tb_ly/blob/e1167e513e300792aff1bec947d1e139e2358f55/Cargo.lock#L7873 So this is because you have a different version installed in your project vs ci, which isn't really a thing the template can fix by pinning to an old version |
|
Thanks for the precisions! I agree that my fix is indeed incorrect (as it will now fail most of the cases). End users tend to commit their cargo.lock though, and when they do, the next update of wasm-bindgen-cli will break the CI, so I think the root issue is worth debating at least. |
|
you can find the version to install with |
See bevyengine#84 Co-authored-by: François Mockers <francois.mockers@vleue.com>
ChristopherBiscardi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lockfile version detection is much better than pinning
|
@ThierryBerger can you please update the PR description/title? Once that's done I'm happy to merge. |
Fix #83
Prevent wasm CI from crashing when a Cargo.lock is commit and a new version of wasm-bindgen-cli is released, effectively installed via its name only in CI, but incompatible with the old one from the lockfile.
This PR addresses this by parsing cargo metadata and installing the same version.