Skip to content

Comments

Fix RTL On Arabic (V4)#128

Closed
mstfkhazaal wants to merge 2 commits intobezhanSalleh:mainfrom
fnx-software:main
Closed

Fix RTL On Arabic (V4)#128
mstfkhazaal wants to merge 2 commits intobezhanSalleh:mainfrom
fnx-software:main

Conversation

@mstfkhazaal
Copy link

Before when i use Arabic Language

CleanShot 2025-08-21 at 00 08 07@2x

After Remove "fi-dropdown-list-item"

CleanShot 2025-08-21 at 00 21 04@2x

@mstfkhazaal mstfkhazaal marked this pull request as ready for review August 20, 2025 21:23
@mstfkhazaal
Copy link
Author

Please Open Issue Page
@bezhanSalleh
I found another issue in profile page when i use isSimple false. ->profile(isSimple: false)

CleanShot 2025-08-21 at 01 05 34@2x

@bezhanSalleh
Copy link
Owner

bezhanSalleh commented Aug 20, 2025

Thanks for the initiative, but i cannot reproduce your issue. better to create an issue first so we can figure out if its package related or app related. Scenarios described in your PR are not reproduceable.
Tested on:
L11.x | L12.x - Filament 4.x - Tailwind 4.x

@mstfkhazaal
Copy link
Author

Thanks for the initiative, but i cannot reproduce your issue. better to create an issue first so we can figure out if its package related or app related. Scenarios described in your PR are not reproduceable. Tested on: L11.x | L12.x - Filament 4.x - Tailwind 4.x

Okay but i cannot create an issue because the issue page is not work you can check https://github.com/bezhanSalleh/filament-language-switch/issues/new

RTL Issue

For First Issue i create this repository https://github.com/mstfkhazaal/filament-4-test/tree/language_switch_test
On English (Work Normaly):
CleanShot 2025-08-21 at 09 05 48@2x

On Arabic i get this:
CleanShot 2025-08-21 at 09 06 23@2x

Profile Issue

The filament profile is a simple page is work normaly (Outside panel)
CleanShot 2025-08-21 at 09 08 41@2x

But if the user disable simple page ->profile(isSimple: false),
CleanShot 2025-08-21 at 09 09 32@2x

Now it is not considered an Outside panel.
I get two language switch

CleanShot 2025-08-21 at 09 11 01@2x

To fix it i disabled auth.profile from outsidePanelRoutes
CleanShot 2025-08-21 at 09 15 19@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants