Skip to content

Comments

Fix Closure evaluation in general#133

Merged
bezhanSalleh merged 2 commits intobezhanSalleh:4.xfrom
gp-lnuff:patch-1
Feb 5, 2026
Merged

Fix Closure evaluation in general#133
bezhanSalleh merged 2 commits intobezhanSalleh:4.xfrom
gp-lnuff:patch-1

Conversation

@gp-lnuff
Copy link
Contributor

Currently throws an error if $locales is a Closure

Currently throws an error if $locales is a Closure
@what-the-diff
Copy link

what-the-diff bot commented Oct 10, 2025

PR Summary

  • Improved accuracy in visibility checking
    This change ensures that when checking if something is visible inside the panels, the program now correctly counts the amount of locales (language regions for the software). Before, it was not taking into account all locales correctly which may have led to inconsistent visibility results. More accurate results mean a better user experience across different language versions of the software.

@gp-lnuff
Copy link
Contributor Author

There were several other places where properties that could be Closures could not be set as Closures, or they could but then they weren't evaluated in some other function that accessed the property, or they couldn't be closures but the getter was evaluating them anyways. I added support for Closure definitions for every property, defined the setters and getters to reflect that, and changed other instances were properties were being accessed direclty instead of evaluated. This should greatly improve flexibility

@gp-lnuff gp-lnuff changed the title Fix Closure evaluation in isVisibleInsidePanels() Fix Closure evaluation in general Oct 13, 2025
@bezhanSalleh bezhanSalleh merged commit eee3e39 into bezhanSalleh:4.x Feb 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants