Skip to content

Rewrite HED code for version 4.0.0 of hed-validator#173

Merged
rwblair merged 6 commits intobids-standard:mainfrom
happy5214:hed-validator-4.0.0
Mar 24, 2025
Merged

Rewrite HED code for version 4.0.0 of hed-validator#173
rwblair merged 6 commits intobids-standard:mainfrom
happy5214:hed-validator-4.0.0

Conversation

@happy5214
Copy link
Contributor

This new version of hed-validator (not yet released) changes the API significantly. This is an early preview of the changes. Tests do not pass with the current release, and they were not attempted with the development branch.

This new version of hed-validator (not yet released) changes the API
significantly. This is an early preview of the changes. Tests do not
pass with the current release, and they were not attempted with the
development branch.
@happy5214 happy5214 marked this pull request as ready for review March 14, 2025 15:11
@happy5214
Copy link
Contributor Author

The test failures are due to actual invalid HED in the examples, and not due to bad code. @VisLab will take care of the example failures.

@effigies
Copy link
Contributor

To be clear, is the invalid HED newly invalid, or is it newly caught by the validator?

@VisLab
Copy link
Member

VisLab commented Mar 14, 2025 via email

@happy5214
Copy link
Contributor Author

bids-standard/bids-examples#486 should fix the remaining test failures.

@happy5214 happy5214 force-pushed the hed-validator-4.0.0 branch from 06b852e to 92c878e Compare March 19, 2025 10:17
@happy5214
Copy link
Contributor Author

The above-linked PR fixed the remaining HED issues, except for one with eeg_ds003645s_hed_library on the no-network tests. This dataset requires the SCORE v1.0.0 library schema, which is not bundled with the validator and must be downloaded from GitHub. How do I disable that dataset for the no-network tests?

@VisLab
Copy link
Member

VisLab commented Mar 19, 2025

The above-linked PR fixed the remaining HED issues, except for one with eeg_ds003645s_hed_library on the no-network tests. This dataset requires the SCORE v1.0.0 library schema, which is not bundled with the validator and must be downloaded from GitHub. How do I disable that dataset for the no-network tests?

Alternatively, we could modify that example to use libraries that are bundled. This would cause the test to pass and would test library schemas, but it would not test whether a schema not bundled could be accessed. Let us know how we should proceed.
@effigies @rwblair

@effigies
Copy link
Contributor

effigies commented Mar 19, 2025

How do I disable that dataset for the no-network tests?

Had to look it up myself and it was as easy to fix as to point you to. Pushed dcebc91, if you want to see where.

@happy5214
Copy link
Contributor Author

Do you want to merge this now, or wait for a 4.0.2 release with the fixes we're discussing in #157?

@VisLab
Copy link
Member

VisLab commented Mar 19, 2025

@effigies Please merge now. 4.0.1 fixes an edge case bug that is needed for some of our datasets.

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. @rwblair Do you want to review (or merge if you trust me)?

@rwblair rwblair merged commit 7becb04 into bids-standard:main Mar 24, 2025
25 checks passed
@happy5214 happy5214 deleted the hed-validator-4.0.0 branch April 8, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments