Rewrite HED code for version 4.0.0 of hed-validator#173
Rewrite HED code for version 4.0.0 of hed-validator#173rwblair merged 6 commits intobids-standard:mainfrom
Conversation
This new version of hed-validator (not yet released) changes the API significantly. This is an early preview of the changes. Tests do not pass with the current release, and they were not attempted with the development branch.
|
The test failures are due to actual invalid HED in the examples, and not due to bad code. @VisLab will take care of the example failures. |
|
To be clear, is the invalid HED newly invalid, or is it newly caught by the validator? |
|
Newly caught. Version 4.0.0 of the hed-validator is a full validator for
the HED specification.
|
|
bids-standard/bids-examples#486 should fix the remaining test failures. |
06b852e to
92c878e
Compare
|
The above-linked PR fixed the remaining HED issues, except for one with |
Alternatively, we could modify that example to use libraries that are bundled. This would cause the test to pass and would test library schemas, but it would not test whether a schema not bundled could be accessed. Let us know how we should proceed. |
Had to look it up myself and it was as easy to fix as to point you to. Pushed dcebc91, if you want to see where. |
|
Do you want to merge this now, or wait for a 4.0.2 release with the fixes we're discussing in #157? |
|
@effigies Please merge now. 4.0.1 fixes an edge case bug that is needed for some of our datasets. |
This new version of hed-validator (not yet released) changes the API significantly. This is an early preview of the changes. Tests do not pass with the current release, and they were not attempted with the development branch.