feat: Validate directories, do not recurse into schema-declared opaque dirs#180
Merged
feat: Validate directories, do not recurse into schema-declared opaque dirs#180
Conversation
effigies
reviewed
Mar 13, 2025
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Member
Author
|
Previous commit made me realize we don't generate an error for non |
effigies
changed the title
effigies
reviewed
Mar 14, 2025
Contributor
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
I've reviewed the walking code and it makes sense. Still need to wrap my head around findDirRuleMatches.
effigies
reviewed
Mar 19, 2025
Contributor
effigies
left a comment
effigies
left a comment
There was a problem hiding this comment.
Part of me thinks we should be able to optimize this further, but in general there will be an order of magnitude fewer directories than files, so I don't want to go too hard unless this turns out to be a noticeable bottleneck.
Some smallish optimizations to short-circuit loops and avoid repeated recursive lookups.
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu>
effigies
added a commit
that referenced
this pull request
Mar 25, 2025
Add scrive for #180 and workflow to check for changes in changelog.d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#176