feat: markdown rendering with ansi-escapes (fixes #328)#347
Closed
BitForge95 wants to merge 2 commits intobids-standard:mainfrom
Closed
feat: markdown rendering with ansi-escapes (fixes #328)#347BitForge95 wants to merge 2 commits intobids-standard:mainfrom
BitForge95 wants to merge 2 commits intobids-standard:mainfrom
Conversation
aa4847b to
6a0e32c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 87.00% 87.00%
=======================================
Files 51 51
Lines 3887 3887
Branches 624 624
=======================================
Hits 3382 3382
Misses 495 495
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This was already merged. We had to pull it out while we dealt with some bugs, but it's in the latest release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-implements the Markdown rendering feature using standard libraries as requested.
It replaces the previous PR #332.
Changes:
npm:supports-hyperlinks(viadeno.jsonimport map) for robust terminal detection.npm:ansi-escapes(viadeno.jsonimport map) for generating link sequences.Closes #328