Skip to content

feat: Memoize readBytes/readText to avoid excess fetches#349

Merged
effigies merged 6 commits intobids-standard:mainfrom
effigies:feat/memoize_read
Feb 2, 2026
Merged

feat: Memoize readBytes/readText to avoid excess fetches#349
effigies merged 6 commits intobids-standard:mainfrom
effigies:feat/memoize_read

Conversation

@effigies
Copy link
Contributor

This treats them the same as loadTSV and loadJSON.

This PR also updates the type signature for filememoize a la #337.

Closes #348.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (2377750) to head (fa42596).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/schema/context.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   87.00%   87.02%   +0.01%     
==========================================
  Files          51       51              
  Lines        3887     3892       +5     
  Branches      624      624              
==========================================
+ Hits         3382     3387       +5     
  Misses        495      495              
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@effigies effigies merged commit acbd58c into bids-standard:main Feb 2, 2026
29 checks passed
@effigies effigies deleted the feat/memoize_read branch February 2, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple fetches per file

2 participants