feat: Memoize readBytes/readText to avoid excess fetches#349
Merged
effigies merged 6 commits intobids-standard:mainfrom Feb 2, 2026
Merged
feat: Memoize readBytes/readText to avoid excess fetches#349effigies merged 6 commits intobids-standard:mainfrom
effigies merged 6 commits intobids-standard:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 87.00% 87.02% +0.01%
==========================================
Files 51 51
Lines 3887 3892 +5
Branches 624 624
==========================================
+ Hits 3382 3387 +5
Misses 495 495
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a95a388 to
51c9504
Compare
nellh
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This treats them the same as
loadTSVandloadJSON.This PR also updates the type signature for filememoize a la #337.
Closes #348.