Open
Conversation
… clipping plane and line builders
… clipping plane and line builders
* [BMSPT-275] implementation of bcf zip creation with memory stream * [BMSPT-275] refactor & reorganization * [BMSPT-275] added unit tests * Simplified IConverter API. Added support for predefined output streams. * [BMSPT-297] Checking incoming streams if they can be used for the given use case. Added documentation. --------- Co-authored-by: DanielLepold <daniel@bimspot.io> Co-authored-by: Adam Eri <adam.eri@blackmirror.at>
…18) * [BMSPT-293] Added cancellation token to Converter stream operations. * [BMSPT-293] Added cancellation token to Converter stream operations. --------- Co-authored-by: Adam Eri <adam.eri@bimspot.io>
…, refactoring, extended worker with converter ToBcf fns, supporting cancellation token and output stream
…re/BMSPT-283-delegate-methods # Conflicts: # bcf-toolkit.sln.DotSettings.user # src/bcf-toolkit/Builder/Bcf21/Interfaces/IViewPointBuilder.cs # src/bcf-toolkit/Builder/Bcf30/Interfaces/IViewPointBuilder.cs # src/bcf-toolkit/Builder/Bcf30/ViewPointBuilder.cs # src/bcf-toolkit/Converter/Bcf21/Converter.cs # src/bcf-toolkit/Converter/Bcf21/FileWriter.cs # src/bcf-toolkit/Converter/Bcf21/SchemaConverterToBcf30.cs # src/bcf-toolkit/Converter/Bcf30/Converter.cs # src/bcf-toolkit/Converter/Bcf30/FileWriter.cs # src/bcf-toolkit/Converter/Bcf30/SchemaConverterToBcf21.cs # src/bcf-toolkit/Model/Bcf21/MarkupExtensions.cs # src/bcf-toolkit/Model/Bcf21/VisInfo.cs # src/bcf-toolkit/Model/Bcf30/MarkupExtensions.cs # src/bcf-toolkit/Program.cs # src/bcf-toolkit/README.md # src/bcf-toolkit/Utils/BcfExtensions.cs # src/bcf-toolkit/Utils/ZipArchiveEntryExtensions.cs # src/bcf-toolkit/Utils/ZipArchiveExtensions.cs # src/tests/Converter/Bcf21/FileWriterTest.cs # src/tests/Converter/Bcf30/ConverterTests.cs # src/tests/Converter/Bcf30/FileWriterTests.cs # src/tests/WorkerTests.cs
…er and converter, fixed and extended tests, extended readme
DanielLepold
reviewed
Sep 6, 2024
Contributor
There was a problem hiding this comment.
pls consider the following solutions for the "return Task.Completed case":
if (_delegate is null) {
throw new InvalidOperationException("IBcfBuilderDelegate is not set.");
}
if (_delegate is null) {
return Task.FromException(new InvalidOperationException("IBcfBuilderDelegate is not set."));
}
DanielLepold
reviewed
Sep 6, 2024
Contributor
There was a problem hiding this comment.
Should the commented-out parts remain for future use?
DanielLepold
reviewed
Sep 6, 2024
Contributor
DanielLepold
left a comment
There was a problem hiding this comment.
Awesome work!
Pls see my comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR includes the delegate callback function and stream process func for converters.
Fixes
Type Of Change
to not work as expected)
API Changes
Environment (Docker)
Checklist