-
Notifications
You must be signed in to change notification settings - Fork 0
feature/dimension-properties #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
15a30ae
feature/dimension-properties
BrianWhitneyAI cb1328a
update metadata label
BrianWhitneyAI 16ecf85
add typing, remove value
BrianWhitneyAI 07ac895
dep update
BrianWhitneyAI cec230c
Merge branch 'main' into feature/dimension-properties
BrianWhitneyAI File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,3 +36,34 @@ class Scale(NamedTuple): | |
| Z: Optional[float] | ||
| Y: Optional[float] | ||
| X: Optional[float] | ||
|
|
||
|
|
||
| class DimensionProperty(NamedTuple): | ||
| """ | ||
| Per-dimension descriptor for dimension metadata. | ||
|
|
||
| value: | ||
| The numeric value for this dimension (e.g. from Scale or PhysicalPixelSizes). | ||
| type: | ||
| Semantic meaning of the dimension (e.g. "spatial", "temporal", "channel"). | ||
| unit: | ||
| Unit string associated with the value (e.g. "micrometer", "second", "index"). | ||
| """ | ||
|
|
||
| value: Optional[float] | ||
| type: Optional[str] | ||
| unit: Optional[str] | ||
|
||
|
|
||
|
|
||
| class DimensionProperties(NamedTuple): | ||
| """ | ||
| Container for dimension properties for all supported dims. | ||
|
|
||
| These align with the standard bioio dimension order (T, C, Z, Y, X). | ||
| """ | ||
|
|
||
| T: DimensionProperty | ||
| C: DimensionProperty | ||
| Z: DimensionProperty | ||
| Y: DimensionProperty | ||
| X: DimensionProperty | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love "properties" in the names here, but the only things I can think of that make it better are words like "metadata" or "info" which aren't a huge step up. Maybe
dimension_infois a little better thandimension_properties? idk...