add a simple description on how to add a new platform#176
Open
KanjiMonster wants to merge 4 commits intomainfrom
Open
add a simple description on how to add a new platform#176KanjiMonster wants to merge 4 commits intomainfrom
KanjiMonster wants to merge 4 commits intomainfrom
Conversation
hilmarm
reviewed
May 15, 2023
Contributor
hilmarm
left a comment
hilmarm
left a comment
There was a problem hiding this comment.
Just a few wording suggestions. I will try the guide next to see if I can add a platform myself
developer_guide.md
Outdated
|
|
||
| ## Adding new platform support | ||
|
|
||
| To add support for a plaform, there are three places that need to be changed: |
Contributor
There was a problem hiding this comment.
Suggested change
| To add support for a plaform, there are three places that need to be changed: | |
| To add support for a plaform, changes will have to be made in three places: |
Contributor
Author
There was a problem hiding this comment.
You changed the sentence but didn't even fix the "plaform" ;P
Also you didn't notice that it says three changes, but actually lists four.
Anyway, rewrote the sentence to active voice as well.
| ``` | ||
|
|
||
| Using this, create a new file named `platform.conf`in a directory named like the | ||
| ONIE machine name [here](https://github.com/bisdn/meta-switch/tree/main/scripts/installer/machine). |
Contributor
There was a problem hiding this comment.
So we want platform.conf to be located in ../installer/machine/<ONIE machine name>/platform.conf ?
Add a small manual on how to add support for a new platform, under the assumption that the platform is supported by ONL and SONIC. Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
KanjiMonster
force-pushed
the
jogo_dev_docs
branch
from
3718c9f to
4f7213d
Compare
* extend the intro, point to Yocto docs * reword and extend steps * fix typos * add testing changes step * add documenation step * add pull requests step Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
Signed-off-by: Jonas Gorski <jonas.gorski@bisdn.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a small manual on how to add support for a new platform, under the assumption that the platform is supported by ONL and SONIC.