refactor(chain)!: remove ChainOracle dependency from CanonicalIter#2034
Draft
oleonardolima wants to merge 1 commit intobitcoindevkit:masterfrom
Draft
Conversation
- use a closure for `is_block_in_chain` instead of passing `chain` and `chain_tip` to `CanonicalIter`, therefore removing it's dependency on `ChainOracle`. - update the `TxGraph::try_list_canonical_txs` to initialize the `CanonicalIter` with a closure querying the `ChainOracle`, update it's API to not return an error anymore. - FIXME: the ChainOracle query error is currently being ignored as the idea is to removed the ChainOracle trait altogether. - FIXME: it's still required to update the APIs from `TxGraph` that depends on the `ChainOracle`.
Collaborator
Author
|
I'll probably close this one, as it's being superseded by #2038. Still need to check if it'll. |
Collaborator
Author
oleonardolima
changed the title
ChainOracle dependency from CanonicalIterChainOracle dependency from CanonicalIter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_block_in_chaininstead of passingchainandchain_tiptoCanonicalIter, therefore removing it's dependency onChainOracle.TxGraph::try_list_canonical_txsto initialize theCanonicalIterwith a closure querying theChainOracle, update it's API to not return an error anymore.TxGraphthat depends on theChainOracle.Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: