fix: change output selection and dust threshold logic#2065
Open
famouswizard wants to merge 1 commit intobitcoindevkit:masterfrom
Open
fix: change output selection and dust threshold logic#2065famouswizard wants to merge 1 commit intobitcoindevkit:masterfrom
famouswizard wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
aagbotemi
reviewed
Oct 23, 2025
Contributor
aagbotemi
left a comment
aagbotemi
left a comment
There was a problem hiding this comment.
Great work @famouswizard. I left a comment for your review.
Comment on lines
+345
to
+350
| let drain_weights = match change_desc.witness_version() { | ||
| Some(WitnessVersion::V1) => DrainWeights::TR_KEYSPEND, | ||
| Some(WitnessVersion::V0) => DrainWeights::WITNESS_V0_KEYSPEND, | ||
| None => DrainWeights::LEGACY_KEYSPEND, | ||
| _ => DrainWeights::TR_KEYSPEND, | ||
| }; |
Contributor
There was a problem hiding this comment.
This code fails to compile due to missing APIs
Collaborator
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
Are you still working on this one ? Please mind @aagbotemi comment above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keychain::Internalinstead of.last()- avoids random external change or panics when no internal descriptor is present.DrainWeightsnow matches the change address type (taproot, segwit, legacy) for accurate fee and dust estimates.>to>=so exact dust-sized change isn’t lost to fees.Notes to the reviewers
small but important cleanup for more predictable change handling and fee estimation. Worth double-checking test coverage for non-taproot outputs.
Changelog notice
fix incorrect change keychain selection, fee estimation, and dust threshold comparison.
Checklists
All Submissions:
New Features:
Bugfixes: