fix: no Debug on Display implementations

[Dmenec]

Description

Fixes #1933, remove the usage of Debug on Display implemetations mentioned in #1881 (comment)

Changelog notice

• Replaced Debug usage with Display messages for InsertDescriptorError, CalculateFeeError and StoreError.
• InvalidMagicBytes now displays expected and actual bytes in hexadecimal instead of using Debug.
• Added a new short_descriptor function to shorten descriptors for concise error output.
• Added detailed SyncRequest Display for Esplora and Electrum examples.

Checklists

All Submissions:

• I have signed all my commits
• I followed the contribution guidelines
• I ran just check, just fmt and just test before committing

[qatkk]

Concept ACK — this approach looks good, thanks for the changes. I ran the tests locally and they all passed.

While trying to recreate the initial issue’s scenario (#1933), I found that bdk_wallet master still references the older API names (list_canonical_txs, filter_chain_unspents, filter_chain_txouts, from_genesis_hash), whereas this PR’s bdk_chain exposes the newer canonicalization API (canonical_iter) and LocalChain::from_genesis. As a result, building bdk_wallet against this PR failed. Is there any branch in bdk_wallet that already adopts the new APIs, so I can test against them?

I have a few small suggestions below. Most of these are nits, but since this PR is already addressing the area, I thought it’d be reasonable to mention them here:

• It might be nice to add a CI to prevent using Debug for Display in future changes.

• In the short_descriptor function, it could be useful to show the last 8 characters of the descriptor so the full checksum is visible.

• A small note on InvalidMagicBytes: it might be helpful to also show any difference between the length of expected and received byte.

[evanlinjin]

Quality work.

Just a couple requested changes:

• Commit messages should contain a scope (as mentioned in the conventional commits spec). The scope should be the name of the package affected: core, chain, example, etc.
• Commits that break the API should be marked with !.

And a nit:

• Error messages should be somewhat consistent. I personally don't think we should suggest actions in the message, just state what the error is.

[evanlinjin]

@Dmenec are you able to make progress on this?

[Dmenec]

@evanlinjin Pushed the updates. Let me know if everything checks out :)

[evanlinjin]

utACK 532e2ec

I'm happy with how this is looking. Unable to test until I have access to a computer again.

[Dmenec]

Having some trouble with the no_std CI check for the esplora crate... Does it actually support no_std, or should be treated as std‑only?

[oleonardolima]

Having some trouble with the no_std CI check for the esplora crate... Does it actually support no_std, or should be treated as std‑only?

@Dmenec It's now fixed on master, a rebase should fix it.

[evanlinjin]

Sorry for the bike-shedding. We're very close.

[oleonardolima]

Overall it looks good, it just need to address Evan's comments.