test: add non-empty coverage for SyncResponse and FullScanResponse#2111
Open
mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
Open
test: add non-empty coverage for SyncResponse and FullScanResponse#2111mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds non-empty test coverage for SyncResponse::is_empty and FullScanResponse::is_empty to prevent regressions where meaningful response data could be misclassified as empty.
Changes:
- Add a test asserting
SyncResponseis non-empty whenchain_updateis set. - Add a test asserting
FullScanResponseis non-empty whenlast_active_indicesis populated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Hi! First contribution here added small tests for is_empty behavior. Happy to adjust anything if needed. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional test coverage for
SyncResponse::is_emptyandFullScanResponse::is_empty.It verifies responses are correctly reported as non-empty when:
SyncResponselast_active_indicesis populated inFullScanResponseThese tests complement the existing default-empty coverage and help prevent
future regressions.
Tests: