Skip to content

test: add non-empty coverage for SyncResponse and FullScanResponse#2111

Open
mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
mubashirrao1122:test/spk-client-is-empty
Open

test: add non-empty coverage for SyncResponse and FullScanResponse#2111
mubashirrao1122 wants to merge 1 commit intobitcoindevkit:masterfrom
mubashirrao1122:test/spk-client-is-empty

Conversation

@mubashirrao1122
Copy link

This PR adds additional test coverage for SyncResponse::is_empty and
FullScanResponse::is_empty.

It verifies responses are correctly reported as non-empty when:

  • a chain update is present in SyncResponse
  • last_active_indices is populated in FullScanResponse

These tests complement the existing default-empty coverage and help prevent
future regressions.

Tests:

  • cargo test -p bdk_core --test test_spk_client

Copilot AI review requested due to automatic review settings February 3, 2026 07:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds non-empty test coverage for SyncResponse::is_empty and FullScanResponse::is_empty to prevent regressions where meaningful response data could be misclassified as empty.

Changes:

  • Add a test asserting SyncResponse is non-empty when chain_update is set.
  • Add a test asserting FullScanResponse is non-empty when last_active_indices is populated.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mubashirrao1122
Copy link
Author

Hi! First contribution here added small tests for is_empty behavior. Happy to adjust anything if needed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant