Rename cancel_tx to unreserve_change_address#326
Open
GideonBature wants to merge 1 commit intobitcoindevkit:masterfrom
Open
Rename cancel_tx to unreserve_change_address#326GideonBature wants to merge 1 commit intobitcoindevkit:masterfrom
GideonBature wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
GideonBature
force-pushed
the
freeing-reserved-utxos
branch
from
e5b8d34 to
3f7ff2d
Compare
Pull Request Test Coverage Report for Build 18323393969Details
💛 - Coveralls |
GideonBature
changed the title
Member
|
@GideonBature can you reword the commit as |
Contributor
Author
|
Noted @luisschwab let me do that now. |
GideonBature
force-pushed
the
freeing-reserved-utxos
branch
from
3f7ff2d to
35faa29
Compare
Contributor
Author
|
This recent push reword the commit message. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=========================================
Coverage ? 85.24%
=========================================
Files ? 23
Lines ? 8229
Branches ? 0
=========================================
Hits ? 7015
Misses ? 1214
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ValuedMammal
reviewed
Dec 9, 2025
| /// This frees up the change address used when creating the tx for use in future transactions. | ||
| // TODO: Make this free up reserved utxos when that's implemented | ||
| pub fn cancel_tx(&mut self, tx: &Transaction) { | ||
| pub fn unreserve_change_address(&mut self, tx: &Transaction) { |
Collaborator
There was a problem hiding this comment.
Hm, ok but it doesn't only unreserve the change address, but the address of every txout having an indexed script pubkey. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames
cancel_tx()tounreserve_change_address()to better reflect its current functionality, which only frees up the change address and does not yet handle UTXO reservation.Changelog notice
Changed
cancel_tx()tounreserve_change_address()for clarityCloses #212