[backport] Add get_pre_1_wallet_keychains migration helper#365
Open
notmandatory wants to merge 1 commit intobitcoindevkit:release/2.xfrom
Open
[backport] Add get_pre_1_wallet_keychains migration helper#365notmandatory wants to merge 1 commit intobitcoindevkit:release/2.xfrom
notmandatory wants to merge 1 commit intobitcoindevkit:release/2.xfrom
Conversation
notmandatory
force-pushed
the
backport/sqlite_pre1_migration_helper
branch
from
b1b9763 to
7624182
Compare
notmandatory
force-pushed
the
backport/sqlite_pre1_migration_helper
branch
from
7624182 to
f19c6fb
Compare
notmandatory
changed the title
Member
Author
|
I'll mark this as ready to review after #364 is merged to make sure they match. |
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
wallet/migrationmodule andget_pre_1_wallet_keychains()to help migrate users from a pre-1.0 bdk sqlite database. This new function returns the last revealed index and checksum value for each keychain it finds.Notes to the reviewers
This is a backport to the
release/2.xbranch of #364.Changelog notice
get_pre_1_wallet_keychainsto assist migration from pre-1.0 bdk wallets. (back ported from 3.x)Checklists
All Submissions:
just pbefore pushingNew Features: