chore(api)!: remove BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs#157
Open
luisschwab wants to merge 5 commits intobitcoindevkit:masterfrom
Open
chore(api)!: remove BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs#157luisschwab wants to merge 5 commits intobitcoindevkit:masterfrom
BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs#157luisschwab wants to merge 5 commits intobitcoindevkit:masterfrom
Conversation
1872024 to
dbbe555
Compare
Pull Request Test Coverage Report for Build 20796560586Details
💛 - Coveralls |
BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txsBlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs
Collaborator
oleonardolima
left a comment
There was a problem hiding this comment.
utACK eccf30d
I'm also wondering on how disruptive it'll be on downstream, see VM's comment, though it'll be in a major release.
Member
Author
|
Makes sense. We can remove the deprecated function on v14. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #142.
Closes #146.
Closes #148.
Closes #150.
This PR:
BlockSummaryand usesBlockInfoforget_blocks, asBlockSummaryfails to capture the full response,PrevOut, which is identical toVout,scripthash_txstoget_scripthash_txs, to maintain the method naming convention.Amountfor all value/fee fields and removedTx::fee(),u64in favor ofWeightonTxand removedTx::weight().