Use System.Threading.Lock in ConcurrentLfu#697
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the LFU cache’s maintenance lock by using the new System.Threading.Lock API when targeting .NET 9+, and extends project targets to .NET 9.0.
- Use
LockwithTryEnter/ExitunderNET9_0_OR_GREATERinstead ofMonitor.TryEnter - Update main project to target
net9.0and bump C# language version to 13.0 - Extend benchmarks to run on
net9.0
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BitFaster.Caching/Lfu/ConcurrentLfuCore.cs | Added conditional compilation to switch from Monitor locks to the new Lock API |
| BitFaster.Caching/BitFaster.Caching.csproj | Added net9.0 target and updated <LangVersion> to 13.0, bumped validation baseline |
| BitFaster.Caching.Benchmarks/...Benchmarks.csproj | Included net9.0 in benchmarks’ <TargetFrameworks> |
Comments suppressed due to low confidence (1)
BitFaster.Caching/BitFaster.Caching.csproj:5
- [nitpick] Bumping the language version to 13.0 might be ahead of official C# releases; consider using a supported preview or the latest stable version to ensure compatibility for all users.
<LangVersion>13.0</LangVersion>
This was referenced Jun 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the
ConcurrentLfulock optimization from #638.Benchmark shows lock try enter is slightly faster: