[PM-31140] Consolidate unpaid subscription handling#6918
Open
amorask-bitwarden wants to merge 7 commits intomainfrom
Open
[PM-31140] Consolidate unpaid subscription handling#6918amorask-bitwarden wants to merge 7 commits intomainfrom
unpaid subscription handling#6918amorask-bitwarden wants to merge 7 commits intomainfrom
Conversation
Contributor
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6918 +/- ##
=======================================
Coverage 56.19% 56.20%
=======================================
Files 1976 1976
Lines 87523 87459 -64
Branches 7809 7787 -22
=======================================
- Hits 49187 49158 -29
+ Misses 36507 36475 -32
+ Partials 1829 1826 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdenney
reviewed
Jan 30, 2026
kdenney
previously approved these changes
Jan 30, 2026
Contributor
kdenney
left a comment
There was a problem hiding this comment.
Nice job!! 🎉 This is way cleaner. I have just a couple of non-blocking questions.
…tion-handling Resolved conflict in SubscriptionUpdatedHandlerTests.cs by using Stripe.Plan explicit type qualification from main.
This reverts commit fe0bc15.
kdenney
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31140
📔 Objective
Consolidates the handling of subscriptions that transition to
unpaidstatus across all entity types (Premium users, Organizations, and Providers).Previously, each entity type was handled differently:
cancel_atwas set on the subscription to 7 days in the futureThis PR standardizes on the Provider approach for all entity types:
cancel_atto 7 days in the futureThis gives customers a consistent 7-day grace period to resolve payment issues before their subscription is canceled, regardless of subscription type.
Additional improvements:
ProrationBehavior.Noneto prevent unintended proration charges during cancellation/reactivationCancellationDetails.Commentfor better audit trail when setting cancellationTesting: Unit tests in
SubscriptionUpdatedHandlerTests.cswere updated to reflect the consolidated behavior and verify the new subscription update options.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes