Skip to content

[PM-30316] Verify OrgId of Invite-Accepting User#6937

Merged
sven-bitwarden merged 2 commits intomainfrom
ac/pm-30316/check-org-membership-on-accept
Feb 5, 2026
Merged

[PM-30316] Verify OrgId of Invite-Accepting User#6937
sven-bitwarden merged 2 commits intomainfrom
ac/pm-30316/check-org-membership-on-accept

Conversation

@sven-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30316

📔 Objective

We execute some checks on an organization when an invited user accepts the invite, but before doing so, we should verify that the organization of the user matches the organization they're accepting the invite to.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sven-bitwarden sven-bitwarden requested a review from a team as a code owner February 2, 2026 21:09
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Logo
Checkmarx One – Scan Summary & Details7b723a23-f5a6-4834-96e3-170dea3ad905

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.24%. Comparing base (26b62bc) to head (50ce315).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6937      +/-   ##
==========================================
+ Coverage   56.19%   56.24%   +0.04%     
==========================================
  Files        1976     1976              
  Lines       87523    87527       +4     
  Branches     7809     7810       +1     
==========================================
+ Hits        49187    49227      +40     
+ Misses      36507    36470      -37     
- Partials     1829     1830       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sven-bitwarden sven-bitwarden merged commit 3e21d12 into main Feb 5, 2026
42 checks passed
@sven-bitwarden sven-bitwarden deleted the ac/pm-30316/check-org-membership-on-accept branch February 5, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants