Skip to content

Fix README to document separate resources for random secrets and keypairs#40

Draft
Copilot wants to merge 2 commits intocurve25519-supportfrom
copilot/sub-pr-39
Draft

Fix README to document separate resources for random secrets and keypairs#40
Copilot wants to merge 2 commits intocurve25519-supportfrom
copilot/sub-pr-39

Conversation

Copy link

Copilot AI commented Feb 17, 2026

The README incorrectly described vaultprov_random_secret with a type field supporting both random_secret and curve25519_keypair. The actual implementation uses two separate resources.

Changes:

  • Updated README to document vaultprov_random_secret and vaultprov_keypair_secret as separate resources
  • Corrected vaultprov_random_secret examples to remove non-existent type parameter
  • Corrected vaultprov_keypair_secret examples to use base_path instead of path
  • Clarified that keypairs are stored as two separate Vault secrets (/base_path/private and /base_path/public), not concatenated

Before:

resource "vaultprov_random_secret" "my_keypair" {
  path = "/secrets/bar/foo"
  type = "curve25519_keypair"  # Wrong resource and parameter
  metadata = { ... }
}

After:

resource "vaultprov_keypair_secret" "my_keypair" {
  base_path = "/secrets/bar/foo"
  type      = "curve25519"
  metadata  = { ... }
}

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: jcbbc <65292153+jcbbc@users.noreply.github.com>
Copy link
Author

Copilot AI commented Feb 17, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkpoint-api.hashicorp.com
    • Triggering command: /tmp/go-build365712177/b001/exe/tfplugindocs /tmp/go-build365712177/b001/exe/tfplugindocs generate --provider-name vaultprov -goversion go1.25.7 -c=4 -nolocalimports -importcfg /tmp/go-build365712177/b245/importcfg -pack lude conf�� 0.1-go1.25.7.lin-pthread ux-amd64/src/net-Wl,--no-gc-sections rg/toolchain@v0.-fmessage-length=0 user.email (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update Curve25519 keypair generation based on feedback Fix README to document separate resources for random secrets and keypairs Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants