feat(oracles): Add timeout when fetching prices#1576
feat(oracles): Add timeout when fetching prices#1576yordanmadzhunkov wants to merge 2 commits intomainfrom
Conversation
yordanmadzhunkov
requested review from
EmilIvanichkovv,
HristoStaykov,
MillaGenova and
Owliie
yordanmadzhunkov
force-pushed
the
yordan/add_timeout_when_fetching_prices
branch
from
2744ab9 to
840bc81
Compare
| ]); | ||
|
|
||
| let fetched_provider_prices = fetch_all_prices(futures_set).await; | ||
| let fetched_provider_prices = fetch_all_prices(futures_set, &Duration::from_secs(5)).await; |
There was a problem hiding this comment.
How much is the deadline for the whole oracle script to be considered failed due to timeout? Maybe we should aim for an interval that is closer to it. Currently, Binance takes around 30s to fetch prices, sometimes even 40s.
There was a problem hiding this comment.
then I should increase this to 59 secs :)
There was a problem hiding this comment.
Currently, Binance takes around 30s to fetch prices, sometimes even 40s
Where have you examined these numbers?
yordanmadzhunkov
force-pushed
the
yordan/add_timeout_when_fetching_prices
branch
from
840bc81 to
1303f3c
Compare
| ]); | ||
|
|
||
| let fetched_provider_prices = fetch_all_prices(futures_set).await; | ||
| let fetched_provider_prices = fetch_all_prices(futures_set, &Duration::from_secs(15)).await; |
There was a problem hiding this comment.
Should we increase this timeout as well, the current voting period of all price feeds is 90 seconds, we could go for the same value as in cex-price-feeds might be?
EmilIvanichkovv
left a comment
EmilIvanichkovv
left a comment
There was a problem hiding this comment.
We can not use tokio in wasm.
If you try to run any of the scripts, you will see
just start-oracle cex-price-feeds
Add metrics WASM_EXECUTION_TIMEOUT_GAUGE
yordanmadzhunkov
force-pushed
the
yordan/add_timeout_when_fetching_prices
branch
from
1303f3c to
6136b52
Compare
🚀 Deployment Links of Blocksense Network websites:
|
5 participants
Currently a stop in Gate.io caused the whole crypto price oracle to stop working, dispute having available data from other exchanges. This PR adds the ability to handle this kind of situation