Provided move constructor and move assignment operator for SpinLock type.#152
Closed
safaruqi wants to merge 3 commits intobloomberg:masterfrom
Closed
Provided move constructor and move assignment operator for SpinLock type.#152safaruqi wants to merge 3 commits intobloomberg:masterfrom
safaruqi wants to merge 3 commits intobloomberg:masterfrom
Conversation
This was referenced Sep 15, 2021
… errors related to deleted copy ctors of atomics Signed-Off-By: Salman A. Faruqi <sfaruqi6@bloomberg.net>
Signed-Off-By: Salman A. Faruqi <sfaruqi6@bloomberg.net>
… add DCO Signed-Off-By: Salman A. Faruqi <sfaruqi6@bloomberg.net>
Contributor
Author
|
Closing this pull request. The fix will be provided in PR #153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #150 *
Describe your changes
Provided move constructor and move assignment operator for SpinLock type. Since the copy constructor for atomics is deleted, we'll need to explicitly define the move constructor and assignment operator.
Testing performed
Was unable to recreate the reported bug in my environment as I don't have those versions of Linux distribution or the version of clang. All the current tests part of Quantum passed. From the reported error messages, which are very clearly pointing to the issue, I feel confident that this fix will resolve the issue. Please try this change and report if it fixes it.
Additional context