fix: clean up storybook demo warnings and deprecated patterns #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove :let={builder} and builder={builder} attributes to use
simplified tabs API without builder pattern.
…nents
Remove :let={builder} and builder={builder} attributes to use
simplified select API without builder pattern.
- Remove unnecessary aschild attribute from collapsible - Fix attribute formatting: sideoffset to side-offset with proper syntax - Remove show_on_hover attribute from dropdown trigger
Add unique ID attributes to prevent conflicts between multiple dropdown menu instances in sidebar components.
Convert component tags to proper Phoenix self-closing format: - Remove unnecessary child content from sidebar_trigger components - Fix self-closing tags for separator, sidebar_rail, and input components - Remove explicit icon content where components have default icons
Reviewer's GuideThis PR cleans up storybook demo components by removing unused imports and deprecated builder patterns, updating HEEx syntax to self-closing tags, adding unique dropdown IDs, and fixing minor attribute formatting to eliminate console warnings. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `storybook/lib/salad_storybook_web/live/demo/sidebar_six.ex:396-393` </location>
<code_context>
class="w-[--radix-dropdown-menu-trigger-width] min-w-56 rounded-lg"
side="right"
align="end"
- sideoffset="{4}"
+ side-offset={4}
>
<.dropdown_menu_label class="p-0 font-normal">
</code_context>
<issue_to_address>
**issue (bug_risk):** Changed sideoffset to side-offset for dropdown menu; check for prop compatibility.
Verify that dropdown_menu uses side-offset as the prop name; otherwise, the offset will not work as intended.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -393,7 +390,7 @@ defmodule SaladStorybookWeb.Demo.SidebarSix do | |||
| class="w-[--radix-dropdown-menu-trigger-width] min-w-56 rounded-lg" | |||
There was a problem hiding this comment.
issue (bug_risk): Changed sideoffset to side-offset for dropdown menu; check for prop compatibility.
Verify that dropdown_menu uses side-offset as the prop name; otherwise, the offset will not work as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses various warnings and deprecated patterns in the storybook demo components to improve code quality and remove console warnings.
Changes Made
import SaladUI.Menustatements from dashboard demo files:let={builder}patterns from tabs and select componentsSummary by Sourcery
Clean up storybook demo components by removing unused imports, deprecated API patterns and redundant attributes, modernizing tag syntax, and adding unique dropdown IDs to eliminate warnings.
Bug Fixes:
Enhancements: