Open
Conversation
Test262 conformance changes
Broken tests (1): |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
==========================================
+ Coverage 47.24% 56.50% +9.25%
==========================================
Files 476 547 +71
Lines 46892 60060 +13168
==========================================
+ Hits 22154 33935 +11781
- Misses 24738 26125 +1387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request closes #4555.
How to reproduce:
Both crash with:
index out of bounds: the len is 0 but the index is 0Additional patterns that trigger the bug:
It changes the following:
Fixed
ScopeIndexVisitor::visit_class_expression_mutto callvisit_function_likewithforce_function_scope: truefor constructors, matching the behavior ofvisit_class_declaration_mut. Previously it calledvisit_function_expression_mutwhich passesfalseforforce_function_scope.Fixed
ScopeIndexVisitor::visit_class_element_mutforStaticBlockto passtrueforforce_function_scope. Previously it passedcontains_direct_evalwhich is unrelated to whether a function scope is pushed at runtime.Both class expression constructors and static blocks always have
HAS_FUNCTION_SCOPEset during bytecode compilation, so the scope analyzer must account for this when assigning scope indices.