chore(prompts): destruct limitOption param for better code readability#457
Open
Simek wants to merge 1 commit intobombshell-dev:mainfrom
Open
chore(prompts): destruct limitOption param for better code readability#457Simek wants to merge 1 commit intobombshell-dev:mainfrom
limitOption param for better code readability#457Simek wants to merge 1 commit intobombshell-dev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 0f1e525 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While going through the codebase I have spotted that
limitOptionparam are partially destructed, and partially used directly by key reference. It seems to me that it makes code a bit harder to read, and understand default values at a glance.How
Destruct
limitOptionparam fully in the function definition for better code readability, apply small tweaks to type definition (combining[]withArray<>for the same type looked really odd).