Skip to content

Comments

importer: add openreads importer#3511

Merged
hughrun merged 2 commits intobookwyrm-social:mainfrom
ilkka-ollakka:feat/openreads_import
Mar 31, 2025
Merged

importer: add openreads importer#3511
hughrun merged 2 commits intobookwyrm-social:mainfrom
ilkka-ollakka:feat/openreads_import

Conversation

@ilkka-ollakka
Copy link
Contributor

@ilkka-ollakka ilkka-ollakka commented Feb 22, 2025

Description

Importer for openreads csv files
https://github.com/mateusz-bak/openreads/blob/master/doc/csv.md seems to be spec. Some items in example csv is not found in there. Work is done mainly by working with example csv and checking linked csv info.

Example CSV file was provided by author of linked issue.

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

@hughrun hughrun mentioned this pull request Mar 31, 2025
14 tasks
@hughrun
Copy link
Member

hughrun commented Mar 31, 2025

you should be able to fix the linting issues pretty easily but I'm not sure what's going on with the migration error.

https://github.com/mateusz-bak/openreads/blob/master/doc/csv.md seems to be spec, some items in
example csv is not found in there. Work is done mainly by working with example csv and checking
linked csv info.
@ilkka-ollakka
Copy link
Contributor Author

Seems that migration errors were more on github action having some issues to setup database. I'll update the PR with linting issues fixed.

@ilkka-ollakka ilkka-ollakka force-pushed the feat/openreads_import branch 2 times, most recently from 640a0fc to bfd91dd Compare March 31, 2025 15:13
@ilkka-ollakka
Copy link
Contributor Author

I was able to reproduce the issue locally when cleaning up cached images and rebuilding container/checking migrations. So maybe some django/python timezone info was updated and it seems to cause the migration need. I'll open separated PR for it.

@hughrun
Copy link
Member

hughrun commented Mar 31, 2025

Thanks @ilkka-ollakka, all looks good to me.

@hughrun hughrun merged commit 1733588 into bookwyrm-social:main Mar 31, 2025
10 checks passed
@ilkka-ollakka ilkka-ollakka deleted the feat/openreads_import branch March 31, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support csv import from OpenReads

2 participants