update aiohttp requirement to fix connectivity to services behind cloudflare#3536
Merged
mouse-reeve merged 1 commit intobookwyrm-social:mainfrom Apr 19, 2025
Merged
Conversation
seems that 3.11.11 version fixes access on services behind cloudflare, most visible finna connector https://docs.aiohttp.org/en/stable/changes.html#id15 most probable reason
ilkka-ollakka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Finna connector seemed to start connectivity issue, more specificly cloudflare stopping requests. I pinpointed the issue to aiohttp and seems that https://docs.aiohttp.org/en/stable/changes.html#id17 matches the problem fixed in version 3.11.11. Updating the dependency fixes the connectivity problem. There is more recent releases, but there are some yanked ones and newer changes seem to be more around tracing.
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests