Split nginx config files and fix flower access config#3540
Merged
mouse-reeve merged 2 commits intobookwyrm-social:mainfrom Apr 19, 2025
Merged
Split nginx config files and fix flower access config#3540mouse-reeve merged 2 commits intobookwyrm-social:mainfrom
mouse-reeve merged 2 commits intobookwyrm-social:mainfrom
Conversation
Also create separated reverse_proxy config so it is more clear what it needs to contain.
14 tasks
Member
|
@bookwyrm-social/code-review I'm not super confident reviewing production configs but this looks like it could fix some longstanding issues with deployment vs dev environments so if someone can take a look at this, that would be great! |
14 tasks
Member
|
This works well for me, and it's a huge improvement to how we're handling nginx files -- thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create separated reverse_proxy nginx config for reverse-proxy setup out from production config. This needs documentation update.
Split nginx location configs to separate file, so same config can be included in development/production/reverse_proxy configs. This helps to keep location handling in sync between setups.
Also configure flower upstream so flower access works in all flows.
This also supersedes #3539 as it was not meaningfull to split changes out.
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests