remove port 8000 from docker-compose as unnecessary for web container#3541
Conversation
nginx doesn't need it to be able to connect to web container, so it just unnecessarily opens the port to outside connections
|
Seems that bw-dev command contains portion to show in which that port is mapped, so it seems to have some use in some cases? |
|
I think maybe we need |
|
The port needs to be opened only if you want to access that development server directly without going via ngixn container. Access via nginx container works in all modes (reverse-proxy, production https and development) fine without it. Seems that it might be there for some historical reason as it has been there since the start of the docker-compose-file, and is not needed anymore? |
|
I'm not sure if there is some use case (debug etc) that needs direct connect to django run development server? |
|
Ok now I see what you mean and have tested this successfully. I can't see any reason we need to directly access |
Description
Nginx container doesn't need it to be able to connect to web container, so it just unnecessarily opens the port to outside connections
What type of Pull Request is this?
Does this PR change settings or dependencies, or break something?
Details of breaking or configuration changes (if any of above checked)
Documentation
Tests