Skip to content

Comments

Update locales and simplifies bw-dev command for loading locales#3544

Merged
mouse-reeve merged 2 commits intomainfrom
update_locales
Apr 15, 2025
Merged

Update locales and simplifies bw-dev command for loading locales#3544
mouse-reeve merged 2 commits intomainfrom
update_locales

Conversation

@mouse-reeve
Copy link
Member

@mouse-reeve mouse-reeve commented Apr 12, 2025

Description

The bw-dev script for updating locales used to manually select which files to copy, which is unnecessarily complicated -- this change will load them all wholesale. I have also updated the locale files themselves.

  • Related Issue #
  • Closes #

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

@mouse-reeve mouse-reeve requested a review from hughrun April 12, 2025 17:38
@hughrun
Copy link
Member

hughrun commented Apr 13, 2025

@mouse-reeve I just want to check my understanding here.

  1. Updates happen to translations in Crowdin
  2. Crowdin pushes new translations to l10n_main as they are available
  3. We run ./bw-dev update_locales whilst in main
    i. All /locale files from l10n_mainare copied into the same folder in the working branch (main)
    ii. Django makes and compiles translations including a en_US reference file
  4. We manually make a PR to merge these locales changes into main
  5. We pull the PR to update locales
  6. There is now a new reference file in en_US
  7. Using the changes in the new reference file, updates happen to translations in Crowdin...

Is that right? And if not, what did I get wrong?

@mouse-reeve
Copy link
Member Author

That's exactly the process!

@mouse-reeve mouse-reeve merged commit f15618d into main Apr 15, 2025
10 checks passed
@mouse-reeve mouse-reeve deleted the update_locales branch April 15, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants