Conversation
|
OK the first draft of a non-hanging, yet clunky, version is in and cycling in CI. Next steps involve:
Cc: @mborland |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1330 +/- ##
=========================================
+ Coverage 98.8% 98.8% +0.1%
=========================================
Files 278 279 +1
Lines 18034 18088 +54
Branches 1918 1926 +8
=========================================
+ Hits 17812 17867 +55
+ Misses 222 221 -1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Hi Matt (@mborland), there are a few things woth discussing that are appearing in CI/CD. On old GCC7 running on Drone, we hit the There is also verbose text regarding a note about some alignment running wild all over the place in CI/CD. It is ugly. I also get it locally. So we should really clean this up Other than that, just the usual headache of CI... |
|
If we can crank up the depth on GCC-7 that's fine with me. I don't think there's anything we can do about the alignment notifications since they're not warnings, just really annoying notifications about a change from like GCC 4.something |
Fine. I don't actually know where the compiler switches for Drone on that runner can be found. Do you have any tip for that? |
Actually, I think the best move is to dump GCC-7 going into our first boost release. We already don't support GCC7 32-bit because it can't hang. |
Yes please. Preferably immediately |
Done, and updated the docs accordingly on this branch. |
Thanks Matt. Now something seemingly unrelated, kind of weird, is happenning on some of the runner environments in GHA? Or is that in Boost's CMake env? |
|
An automated preview of the documentation is available at https://1330.decimal.prtest3.cppalliance.org/libs/decimal/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-02-05 13:40:47 UTC |
It's an ubuntu problem. Happens from time to time. |
Got it. Thanks |
|
Note to self: One of the recent failed runners picks up I'll disable the warning locally here, but this should be properly determined (which compiler picks it up) and dealt with in Multiprecision. Cc: @mborland |
|
I think I need some help. Matt (@mborland) do you see why the runner could still pick up How do we identify that compiler via preprocessor? From the build log, it looks like clang 17 on |
The macro |
Oh cool this clears up a lot. I always thought it behaved like Now this issue is sitting in I could repair them all myself prior to 1.91, but nobody is complaining about it. Your thoughts Matt? |
|
For a small change we still have a few weeks. I think all the types already have warning wrappers around these deprecated members for MSVC |
That is correct. I looked this morning. All I'll find a minute to make an issue in MP. |
|
So I'm still going to do 1 more push on this branch to hit the 4 missing cover lines (2 each) in Then that should be about that for this one. But I'll still need another day maybe. |
A billion no-hang runs locally. Lets progress here.
See also #1329