buzhash64e: with rolling hash encryption#8920
Draft
ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
Draft
buzhash64e: with rolling hash encryption#8920ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
ThomasWaldmann wants to merge 3 commits intoborgbackup:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8920 +/- ##
=======================================
Coverage 81.43% 81.43%
=======================================
Files 77 77
Lines 13515 13516 +1
Branches 2004 2004
=======================================
+ Hits 11006 11007 +1
Misses 1853 1853
Partials 656 656 ☔ View full report in Codecov by Sentry. |
8f120dd to
bf26a50
Compare
bf26a50 to
c603fb4
Compare
|
(As a sidenote on speed). I've found it quite interesting that fast PCG RNG (numpy's default prng) is predictable, but seed reconstruction out of 64 consecutive values is a non-trivial operation — 2¼ CPU-years of computation. However, it's still just a €108, if we assume a CPU core to cost 4 €/month. |
Encrypting the rolling hash should make it better resist against attacks. use aes128-ecb (slow, not optimized)
this will detect if there is anything going wrong regarding deduplication with the encrypted buzhash mode.
c603fb4 to
e7ad355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather simple and very slow encryption code, needs to be tuned later IF we find this worthwhile doing.
Note:
.encrypt_many()call and then do another loop over the esums to decide where to cut. would be much less overhead than now, but needs maintaining yet another buffer efficiently.