Skip to content

Improve break lock dialog button clarity#2349

Merged
m3nu merged 2 commits intoborgbase:masterfrom
m3nu:fix/break-lock-dialog-wording-2315
Jan 23, 2026
Merged

Improve break lock dialog button clarity#2349
m3nu merged 2 commits intoborgbase:masterfrom
m3nu:fix/break-lock-dialog-wording-2315

Conversation

@m3nu
Copy link
Contributor

@m3nu m3nu commented Jan 20, 2026

Summary

  • Changes lock timeout dialog buttons from "Abort"/"Continue" to "Cancel"/"Break the lock"
  • Makes the dangerous action (breaking the lock) clearly labeled
  • Makes the safe action (cancel) less intimidating

Fixes #2315

Test plan

  • Lint passes
  • test_create_lock test passes

@m3nu m3nu force-pushed the fix/break-lock-dialog-wording-2315 branch from b58dda8 to 87b5603 Compare January 20, 2026 20:16
The lock timeout dialog was confusing because "Continue" was used for the
dangerous action (breaking the lock) while "Abort" was used for the safe
action (cancel). Change buttons to "Cancel" and "Break the lock" for clarity.
@m3nu m3nu force-pushed the fix/break-lock-dialog-wording-2315 branch from 87b5603 to 3229ab8 Compare January 20, 2026 20:16
@m3nu m3nu merged commit 72d84f0 into borgbase:master Jan 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Abort or break the lock" buttons are unnecessarily (possibly dangerously) confusing

1 participant