Improve break lock dialog button clarity#2349
Merged
m3nu merged 2 commits intoborgbase:masterfrom Jan 23, 2026
Merged
Conversation
b58dda8 to
87b5603
Compare
The lock timeout dialog was confusing because "Continue" was used for the dangerous action (breaking the lock) while "Abort" was used for the safe action (cancel). Change buttons to "Cancel" and "Break the lock" for clarity.
87b5603 to
3229ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2315
Test plan
test_create_locktest passes