Remove unused self.selected_archives variable in ArchiveTab (#2388)#2389
Open
mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
Open
Remove unused self.selected_archives variable in ArchiveTab (#2388)#2389mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
mr-raj12 wants to merge 1 commit intoborgbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
self.selected_archives = NonefromArchiveTab.__init__()insrc/vorta/views/archive_tab.py. This instance variable was initialized but never readanywhere in the codebase. It already had a
# TODO: remove unused variablecomment.Note: The local variable
selected_archivesused elsewhere in the same file (lines 532, 973) is unrelated — those are local variables, not the instanceattribute.
Related Issue
Closes #2388
Motivation and Context
Dead code cleanup. The variable was write-only and flagged with a TODO for removal.
How Has This Been Tested?
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.