Fix timezone handling for Borg 2.x archive timestamps (#2390) #2391
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert Borg 2.x UTC timestamps to local time before storing as naive datetimes.
Borg 2.x returns timestamps with UTC timezone info (e.g.,
2018-11-06T14:24:04+00:00). The old code stripped timezone with.replace(tzinfo=None), storingraw UTC values that displayed incorrectly as local time in the UI.
Changes (2 files):
src/vorta/borg/create.py:25.astimezone()before.replace(tzinfo=None)src/vorta/borg/list_repo.py:57Behavior:
.astimezone()on naive datetime assumes local timeRelated Issue
Closes #2390
Motivation and Context
Users in non-UTC timezones would see incorrect archive times when using Borg 2.x. A backup made at 9:24 AM local (EST) would display as "14:24" (the raw UTC
value).
How Has This Been Tested?
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.