Added SparklinesInteractiveLayer#119
Open
vegetableman wants to merge 1 commit intoborisyankov:masterfrom
Open
Conversation
|
@borisyankov are we going to have this similar interactive layer at some point? |
|
Great PR! Just what I was looking for. Question. Did you need an updated version of If not, it's probably making the scope for this PR bigger than it should |
Author
|
It's been 3 years... time sure passes. Anyways, @qcho had to check my code again. On the issue, I updated Have updated the PR now and I have removed fragment, reverted the versions back to old one and now am using the svg Cheers! |
qcho
approved these changes
Sep 7, 2021
tobilg
pushed a commit
to tobilg/react-sparklines-next
that referenced
this pull request
Nov 10, 2025
, borisyankov#122, borisyankov#130 - PR borisyankov#46: Add gap support for null/NaN/Infinity values in data - Modified dataToPoints to mark invalid values with valid flag - Created segmentPoints utility to split data into valid segments - Updated SparklinesLine, SparklinesCurve, and SparklinesBars to handle gaps - Added comprehensive tests for gap handling - PR borisyankov#113: Add fillInvert style option to SparklinesLine - Allows inverting the fill direction for line charts - PR borisyankov#119: Add SparklinesInteractiveLayer component - New component for interactive hover/click with visual feedback - Shows active point with circle and vertical line - PR borisyankov#122: Remove empty onMouseMove handler from SparklinesLine - Made tooltips conditional on onMouseMove presence - PR borisyankov#130: Update README with improved code examples - Use proper JSX syntax highlighting - Wrap examples in function components All tests passing (25 tests across 5 test files)
tobilg
pushed a commit
to tobilg/react-sparklines-next
that referenced
this pull request
Nov 10, 2025
- Document gap support for null/NaN/Infinity values - Add section for fillInvert style option (PR borisyankov#113) - Add section for SparklinesInteractiveLayer component (PR borisyankov#119) - Standardize all code examples with proper JSX syntax and function wrappers - Improve formatting with bold property names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it a little interactive