Corrected typo without breaking backwards compatibility#3398
Open
nuvious wants to merge 3 commits intoboto:developfrom
Open
Corrected typo without breaking backwards compatibility#3398nuvious wants to merge 3 commits intoboto:developfrom
nuvious wants to merge 3 commits intoboto:developfrom
Conversation
…d via a named import.
…ack unnecessarily. Also reversed the search since imports tend to be low on the stack.
…up in the inspect stack; ended up being erroneous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the note about the misspelled variable in #3029 which was mentioned in #2361 and #1861. The concerns about breaking backwards compatibility were important and actually sparked interest if this was resolvable. I sought to solve this issue while meeting the following requirements:
I used a mix of
inspectfunctionality and very basic regex to achieve the above to the best of my understanding pending your review.Python 3.8-3.12 local test using tox below; had a residual 3.13 environment that made me have to run it separately:

Python 3.13 test run separately after cleaning the 3.13 environment:

Ran
pre-commitper the Contribution guide but it seemed to skip all the tests for some reason:Also ran

ruffindependently on edited files:Ran

isortand neither file edited was modified, so that's good as well.Below is the final result in terms of user experience if they attempt a module or named import:
May be a bit trivial, but below shows imports of the old variable name have changes reflected in the corrected one via pass by reference convention:
Standing by for any questions, comments, recommendations or direction.