Fix empty drop creation when empty trans-units are pending translation#990
Draft
wadimw wants to merge 2 commits intobox:legacyfrom
Draft
Fix empty drop creation when empty trans-units are pending translation#990wadimw wants to merge 2 commits intobox:legacyfrom
wadimw wants to merge 2 commits intobox:legacyfrom
Conversation
Author
|
This is probably the simplest solution for this case of empty drop creation problem, though it's not complete. One could argue that: Additionally, it's worth noting that there is currently no way to manually change status of an empty trans-unit in Webapp UI, so if we decide on c. we should fix that as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario
An empty trans-unit gets pushed to Mojito.
It shows up with Needs Translation status but has 0 words.
A drop export is triggered for the repository where all other trans-units have already been translated.
Drop will still get created, because Mojito sees that some trans-unit still needs translation - however, this drop will be empty because a 0-word trans-unit is not included in the drop.
Fix
Updated drop-export command to check if any words need translation, rather than trans-units.