This repository was archived by the owner on May 26, 2022. It is now read-only.
[DX] more helpful exception message in case of invalid value#822
Open
andrew-demb wants to merge 7 commits intobox:masterfrom
Open
[DX] more helpful exception message in case of invalid value#822andrew-demb wants to merge 7 commits intobox:masterfrom
andrew-demb wants to merge 7 commits intobox:masterfrom
Conversation
…n message - add classname to message
…helpful exception message (in case of objects, for example)
Collaborator
|
Hi! |
Contributor
Author
|
Yes, it was output NULL because So PR propose change |
adrilo
reviewed
Jun 23, 2021
Co-authored-by: Adrien Loison <adrilo@users.noreply.github.com>
Contributor
Author
|
Probably Travis CI check should be retried because PR check status was not changed to finished status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is should provide a more helpful message for developer in exception, when in cell value provided an object.
Example:
Exception:
I may assume, that in my code somewhere used
nulland passed tospout, but the real reason was - object was provided for cell value, and this lead to described above exception.This PR will improve an error message and provide a better DX.