Add locale-aware number parsing with thousands separator support#25
Open
pavitra-infocusp wants to merge 2 commits intobpierre:mainfrom
Open
Add locale-aware number parsing with thousands separator support#25pavitra-infocusp wants to merge 2 commits intobpierre:mainfrom
pavitra-infocusp wants to merge 2 commits intobpierre:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for parsing formatted number strings with thousands separators directly into the
from()function. This creates a complete round-trip workflow whereformat()can produce formatted strings andfrom()can parse them back without additional processing.Motivation
The
format()method returns strings with thousands separators for better readability. However, there was no way to parse these formatted strings back into Dnum values. Users had to manually remove separators before usingfrom(). Additionally, different locales use different separators (e.g., commas in US format, dots in German format), making a locale-aware solution valuable.Implementation
parseLocaleNumber()function: Intelligently detects the system's decimal separator using(1.1).toLocaleString()and normalizes formatted stringsfrom()function now detects commas in input strings and applies locale-aware parsingChanges
from()to detect and parse formatted strings before validation"12,345.29387"→12345.29387.29,387) and negative numbersTesting
LC_ALL='de-DE.UTF-8')Discussion
Question for maintainers: Should we add an optional
localeparameter tofrom()to allow users to explicitly specify the locale format, while maintaining auto-detection as the default fallback? This would provide more explicit control for edge cases while keeping the API simple for most users.