Open
Conversation
Move Issuer Fetch Out of Loop
Experiment: Don't wait for processing to complete before committing the kafka offset
Append unmarshaling errors to the result set Instead of using hard coded constants, create an enum to contain various redemption statuses. This change does not remap the existing values and so does not require an ads-serve change.
Rather than using a new enum, use the enum generated by gogen-avro for status management. Also make log lines shorter by splitting across multiple lines.
saberistic
suggested changes
Mar 22, 2022
| err = Emit(producer, resultSetBuffer.Bytes(), logger) | ||
| if err != nil { | ||
| message := fmt.Sprintf("Request %s: Failed to emit results to topic %s", tokenRedeemRequestSet.Request_id, producer.Topic) | ||
| message := fmt.Sprintf( |
There was a problem hiding this comment.
we should increase Prometheus counters on these unexpected cases and wire alert manager to notify us.
There was a problem hiding this comment.
right before all return utils.ProcessingErrorFromErrorWithMessage(err, message, msg, logger) instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.