fix: log info when UnrecoverableExceptionInterface#101
Closed
alexndlm wants to merge 1 commit intobrefphp:masterfrom
Closed
fix: log info when UnrecoverableExceptionInterface#101alexndlm wants to merge 1 commit intobrefphp:masterfrom
alexndlm wants to merge 1 commit intobrefphp:masterfrom
Conversation
If the application throws `UnrecoverableExceptionInterface`, it is not an error.
Member
|
Why? I consider this exception to be a marker of an error that wouldn't make sense to retry, no? Are there docs about what this exception means exactly (or in which case it is used)? |
Author
|
Yes, exactly. But the main goal for this exception is to not retry intentionaly. Related docs - https://symfony.com/doc/current/messenger.html#avoiding-retrying |
Member
|
In the native Messenger implementation, in case of a non-retryable exception ( I don't see a reason to switch the log level here, am I missing anything? |
Author
|
Nice point. No arguments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the application throws
UnrecoverableExceptionInterface, it is not an error.