Conversation
|
Thank you for the contribution. I've been meaning to simply get rid of the vendor directory in this branch but haven't since I'm working on the v2 replacement. I'd rather we just remove the vendor directory entirely. |
The 'vendor' directory was removed because it keeps getting outdated compared to go.mod. Otherwise 'make test' fails with: $ make test go test -v -cover ./... go: inconsistent vendoring in /path/to/briandowns/spinner: golang.org/x/sys@v0.0.0-20220412211240-33da011f77ad: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt golang.org/x/sys@v0.0.0-20210615035016-665e8c7367d1: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod To ignore the vendor directory, use -mod=readonly or -mod=mod. To sync the vendor directory, run: go mod vendor make: *** [Makefile:12: test] Error 1 Fallout from 12e6c29
6e9b126 to
508a84e
Compare
|
Thanks for the review!
I have now removed the |
|
Some of the vendor removal might have already occurred in #163, I think. |
Indeed. It fixed |
|
The original motivation for this pull request no longer applies. However, if you want to remove the rest of the |
The
vendordirectory was updated withgo mod vendor.Otherwise
make testfails with:Fallout from 12e6c29