DDP-5671 added script to allow bulk cancellation of orders in GBF#126
Open
DDP-5671 added script to allow bulk cancellation of orders in GBF#126
Conversation
zyme
commented
Mar 8, 2021
| @@ -0,0 +1,13 @@ | |||
| package org.broadinstitute.dsm.model.gbf; | |||
|
|
|||
| import com.google.gson.annotations.SerializedName; | |||
Collaborator
Author
There was a problem hiding this comment.
Added a few model classes to match the GBF APIs
zyme
commented
Mar 8, 2021
|
|
||
| public GBFRequestUtil() { | ||
| static { | ||
| initTrust(); |
Collaborator
Author
There was a problem hiding this comment.
Before this change, even if you were calling a static method, you would have had to new up an object, lest you would see an NPE because various static methods assume that blindTrustEverythingExecutor has been initialized. Now it gets initialized automagically.
zyme
commented
Mar 8, 2021
| catch (Exception e) { | ||
| } catch (Exception e) { | ||
| logger.error("Starting up the blindTrustEverythingExecutor ", e); | ||
| System.exit(-3); |
Collaborator
Author
There was a problem hiding this comment.
This is a bit scary--a constructor that calls System.exit() can bring down the entire app!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From time to time, we need to cancel orders with GBF in an adhoc manner. Rather than fiddling with tests and running the risk of uncommenting
@Ignore, I thought a CLI would be nice, so I write this.