Open
Conversation
zyme
commented
Jun 28, 2021
|
|
||
| @Ignore | ||
| @Test | ||
| public void testOrderForParticipant() throws Exception { |
Collaborator
Author
There was a problem hiding this comment.
The only thing going on here was placing an order, so in the spirit of not doing stuff like this in a "test", it's gone!
pegahtah
reviewed
Jun 28, 2021
src/main/java/org/broadinstitute/dsm/model/birch/RegisterBirchOrderCLI.java
Outdated
Show resolved
Hide resolved
pegahtah
approved these changes
Jun 29, 2021
yufengwng
reviewed
Jul 1, 2021
src/main/java/org/broadinstitute/dsm/model/birch/RegisterBirchOrderCLI.java
Outdated
Show resolved
Hide resolved
src/main/java/org/broadinstitute/dsm/model/birch/RegisterBirchOrderCLI.java
Outdated
Show resolved
Hide resolved
zyme
commented
Jul 1, 2021
| private static final String USAGE = "args in order are hruid, kitLabel, externalOrderNumber, and collectionTime\n" + | ||
| "for example java -Dconfig.file=... RegisterBirchOrderCLI P1234 TBOS-123 12345678910111213 06/30/2020 15:34\n" + | ||
| "Make sure you are on a broad network\n"; | ||
| public static final String DATE_FORMAT = "MM/dd/yyyy HH:mm"; |
Collaborator
Author
There was a problem hiding this comment.
@yufengwng your suggestion worked once I updated this from hh to HH (I've been putting in hours as 0-23).
There was a problem hiding this comment.
Noted! And it's helpful that the "usage" string shows an example of 15:34 hinting at 24-hr format!
Collaborator
Author
|
Ready for re-review |
pegahtah
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DDP-6484 provides a one-off java CLI for placing CareEvolve orders for kits that arrive without UPS data. See DDP-6484 for more details.
To test this on dev, I used the following set of args:
P02133 TBOS-100006T XWPE86O8WIYS2XWO228J "01/01/1970 00:00"As for the "test" class, it was a temporary measure for placing orders. The new CLI is much better, so I've removed the "test".