Reconciler API pooling #1539
Draft
Reconciler API pooling #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue BRU-3433 to reduce API call frequency: - Replace errgroup.Group with conc.Pool in claudecode, python, and r packages - Use WithMaxGoroutines(2).WithErrors() for pipe consumption (stdout/stderr) - Reduce BigQuery pool sizes from max(runtime.NumCPU(), 8) to min(runtime.NumCPU(), 4) - Fix r/runner.go to wait for pipe consumption before cmd.Wait() (matching python/local.go pattern) The conc.Pool package provides better control over goroutine limits and the reduced pool sizes help prevent hitting API rate limits too frequently. Co-authored-by: burak.karakan <burak.karakan@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
errgroup.Groupwithconc.Pooland reduced BigQuery pool sizes to decrease Kubernetes API call frequency and improve concurrency control.The change to
conc.Poolwith explicit goroutine limits (2 for pipe consumption, 4 for BigQuery) provides more granular control over concurrency, directly addressing the issue of hitting the Kubernetes API too frequently. Additionally, the error handling order for command execution and pipe consumption was standardized acrossclaudecode,python, andrrunners to ensure pipes are fully read before the command exits, preventing potential deadlocks.Linear Issue: BRU-3433