Conversation
Contributor
Author
|
@brunomioto 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: brunomioto <10459392+brunomioto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates all HTTP requests in the reservatoriosBR package from direct URL calls to using the modern httr2 package for improved reliability and error handling.
Changes Made
Before:
After:
Implementation Details
R/utils-http.R:http_get_html(): Makes HTTP requests and returns content for HTML parsinghttp_get_json(): Makes HTTP requests and returns parsed JSON datareservatorio_cantareira()reservatorio_sin()reservatorio_nordeste_semiarido()ultima_medicao()ONS_reservatorios()Benefits
Backward Compatibility
All function APIs remain unchanged - users can upgrade seamlessly without modifying their code. The migration is completely internal to the package implementation.
Fixes #20.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.r-project.org/usr/lib/R/bin/exec/R -e install.packages(c('devtools',~+~'httr2',~+~'rvest',~+~'glue',~+~'janitor',~+~'dplyr',~+~'jsonlite',~+~'magrittr',~+~'readr',~+~'usethis',~+~'tibble',~+~'tidyr'),~+~repos='REDACTED')(dns block)cran.r-project.org/usr/lib/R/bin/exec/R -e options(repos='REDACTED');~+~install.packages('httr2')(dns block)cran.rstudio.com/usr/lib/R/bin/exec/R -e install.packages(c('devtools',~+~'httr2',~+~'rvest',~+~'glue',~+~'janitor',~+~'dplyr',~+~'jsonlite',~+~'magrittr',~+~'utils',~+~'readr',~+~'usethis',~+~'tibble',~+~'tidyr'),~+~repos='REDACTED')(dns block)esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.