UserID is not the relevant value here, it’s the public key (identityKey)#708
Open
UserID is not the relevant value here, it’s the public key (identityKey)#708
Conversation
Check identityKey when checking certs
Contributor
Manual Testsℹ️ Remember to ask team members to perform manual tests and to assign |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Check identityKey when checking certs
Description of Changes
During Certificate Acquisition we don't need to validate UserID, which is just an internal auto-incrementing ID number; rather we ought to be checking the identityKey which is a universally applicable pubKey.
Linked Issues / Tickets
Unsure, but this fixes:
Running this example code against a go-wallet-toolbox instance locally.
Testing Procedure
I ran the example code, once with no changes which failed:
RPC Error: access is denied due to an authorization errorrunning after making these changes results in successful issuance.
Checklist: