Skip to content

UserID is not the relevant value here, it’s the public key (identityKey)#708

Open
sirdeggen wants to merge 1 commit intomainfrom
fix/certificate-issuance
Open

UserID is not the relevant value here, it’s the public key (identityKey)#708
sirdeggen wants to merge 1 commit intomainfrom
fix/certificate-issuance

Conversation

@sirdeggen
Copy link
Contributor

@sirdeggen sirdeggen commented Dec 15, 2025

Check identityKey when checking certs

Description of Changes

During Certificate Acquisition we don't need to validate UserID, which is just an internal auto-incrementing ID number; rather we ought to be checking the identityKey which is a universally applicable pubKey.

Linked Issues / Tickets

Unsure, but this fixes:

Running this example code against a go-wallet-toolbox instance locally.

Testing Procedure

I ran the example code, once with no changes which failed:
RPC Error: access is denied due to an authorization error

running after making these changes results in successful issuance.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run the linter

@github-actions
Copy link
Contributor

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant