btcjson: fix StringOrArray JSON marshaling and add warnings to GetBlockChainInfoResult #2476
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MarshalJSON method was calling json.Marshal(h) where h is of type StringOrArray. Since StringOrArray implements json.Marshaler, this caused json.Marshal to call MarshalJSON again, resulting in infinite recursion and a stack overflow. Fix by converting to the underlying []string type before marshaling, which breaks the interface lookup cycle. Closes btcsuite#2369 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Bitcoin Core added a warnings field to getblockchaininfo in PR #10858, and recently changed it from a string to an array in PR #29845. Add the field using StringOrArray type to handle both formats. This allows rpcclient to properly unmarshal getblockchaininfo responses from all Bitcoin Core versions. Closes btcsuite#2444 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
StringOrArray.MarshalJSONby converting to underlying[]stringtype before marshalingWarningsfield toGetBlockChainInfoResultusingStringOrArraytypeBackground
The
StringOrArray.MarshalJSONmethod was callingjson.Marshal(h)which caused infinite recursion because Go sees thathimplementsjson.Marshalerand callsMarshalJSON()again.Bitcoin Core added a
warningsfield togetblockchaininfoin PR #10858, and recently changed it from a string to an array in PR #29845. UsingStringOrArrayhandles both formats.Test plan
StringOrArray.MarshalJSONno longer causes stack overflowGetBlockChainInfoResultcan unmarshal warnings as string or arrayCloses #2369
Closes #2444
🤖 Generated with Claude Code